-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Typing][C-91, C-92] Add annotations for python/paddle/incubate/operators/{softmax_mask_fuse, softmax_mask_fuse_upper_triangle}.py
#66867
Conversation
…ftmax_mask_fuse.py'
…ftmax_mask_fuse_upper_triangle.py'
你的PR提交成功,感谢你对开源项目的贡献! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
标注的没啥问题, CI 检查错误,是因为文件名与函数名重名了 ~
可以在示例代码中添加 ignore
,如:
rst = incubate.softmax_mask_fuse_upper_triangle(x) # type: ignore[operator]
这里的两个示例都需要改一下 ~
…tors/{softmax_mask_fuse, softmax_mask_fuse_upper_triangle}.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ~
PR Category
User Experience
PR Types
Improvements
Description
类型标注:
Related links
@SigureMo @megemini